Suggestions

Couple additions if we could:

With icons, can we have one that shows Chat?  There's a lot of quests now that ask you to chat to someone, so an icon resembling this would be great.

Can we auto-detect the provision of a buff?  Quite a few quests require you to do something, where you get a spell cast on you (sometimes visible, sometimes hidden) - a way to check if this buff is on you would be great.  For example, |SPELL|47014| would move onto the next step if you have the buff for spell 47014 on you.

Comments

Can't load 05_12_Snowflake_Eversong_Woods.lua

Hi.

I've come back to WoW and wow-pro after a long absence. I love this add-on and frankly can't see the point of playing WoW without it.

So I've come back to a low level char to get back into it, but when I load the 05_12_Snowflake_Eversong_Woods.lua guide I get the following message:

Step f [Falconwing Square] has a bad |Z|Eversong Woods| tag.

I'm happy to debug and fix this, but a few pointers would be appreciated.

 

If I'm understanding correctly, the issue seems to come right at the start of the lua file:

f Falconwing Square|QID|9704|M|46.24,46.80|N|Get the flightpoint from Skymaster Skyles|

How to interpret and fix this?

 

Cheers

PM

Ludovicus_Maior's picture

BUFF detection

Fluclo asked:

Can we auto-detect the provision of a buff? 

Yup!   In the darkmoon fair guide:

N Sayge's Dark Fortunes|M|52.94,75.94|BUFF|23735;23736;23737;23738;23766;23767;23768;23769|N|Sayge offers different 2 hour buffs.  Pick one and elect to get a written fortune for a chance at a quest item! We pre-select based on your class.|

This detects the BUFF and autocompletes if present.

Estelyen's picture

...which means that the Guide

...which means that the Guide Syntax page requires another update ;)

Life isn't like a box of chocolates, it's more like a jar of jalapeños: What you do today might burn your a** tomorrow.

~Garfield

Ludovicus_Maior's picture

Yes Mam! (Plus a inkling of things to come)

... and anytime I hear those words, I obey :-).  Guide Syntax updated.

I'm playing with an extension to the Professions guide that will introduce a new tag |RECIPIE|xxx|, which will let a step complete if you know the recipie in one of your trades.

I intend to use to use it to compile a list of all the vendor purchaseable items for a given profession. These shopping guides would optionally let you restrict to recipies you don't know but can learn, or restrict to only those you can learn or remove all restriuctions so you can buy for selling on the AH. 

It will also lend itself to some of the world events where cooking is featured.

I had started compiling a list of vendored recipies when I realized it looked an awful lot like a guide.

Emmaleah's picture

chat icon

I would so use it ;).  I poked around a bit to see if I could figure how to add it in and gave up.  I would REALLY love it to be implemented.

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

I would suggest |CHAT| that

I would
suggest |CHAT| that will display the chat bubble (in place of the !, ?,
Combat, Non Combat, Buy icons).  I achieved this by making the following
changes:

WoWPro\WoWPro.lua- around line 237 add to the end of the Core Tag Setup "ischat"

WoWPro\WoWPro_CurrentGuide.lua- add around line 190    if WoWPro.ischat[ index ] then       row.action:SetTexture("Interface\\GossipFrame\\Gossipgossipicon")    endWoWPro\WoWPro_Parser.lua- around line 275 add    if text:find("|CHAT|") then WoWPro.ischat[i] = true end- around line 547 add    if WoWPro.ischat[k] then       row.action:SetTexture("Interface\\GossipFrame\\Gossipgossipicon")    endWoWPro_Leveling\WoWPro_Leveling_CurrentGuide.lua- around line 130 add    if WoWPro.ischat[ index ] then       row.action:SetTexture("Interface\\GossipFrame\\Gossipgossipicon")    endWoWPro_Leveling\WoWPro_Leveling_Parser.lua- around line 288 add        if text:find("|CHAT|") then WoWPro.ischat[i] = true end- around line 455 add    if WoWPro.ischat[k] then       row.action:SetTexture("Interface\\GossipFrame\\Gossipgossipicon")    end(This
only set up for the Levelling guides - there was a lot of duplicated
code in the folders, so it's probably copying the same code in other
places too)I then found that by putting in |CHAT| into a given
step will display the chat symbol instead of whatever symbol would
otherwise show on both the main window and the guide list.</p>

Wow, that WYSIWYG display

Wow, that WYSIWYG display totally doesn't come out like that.  Hopefully you can make out what the above says <fingers crossed>

Emmaleah's picture

if you click on input format,

if you click on input format, then chose BBCode, things line up much more nicely :)  (of course once someone replys to your post you can no longer edit it... /sigh)

and thank you so much for figuring this out! I have wanted this! (of course now to go back and change the old guides /sigh)

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Ludovicus_Maior's picture

Re: if you click on input format, ...

LOL, I am used to worse things.

I'll put it into the queue for the next release.   Too late for the current update.

Emmaleah's picture

Tested proposed changes

I went thru and tested these changes and it works for me.  It would be nice if Ludo has time and can work his magic and make it available to all modules. 

I edited the Hellfire Peninsula (Horde) guide since that is the zone I am currently playing thru to take advantage of this change.  I like it. one comment tho, the icon that Fluclo picked. it has the chat icon upside down. is there another one? or is that all that is available (upside down means the chat bubble tail thing... is coming out of the top instead of the bottom) 

Since you said you arent going to put this change in the next release, I will wait until you post said next release, then I will post my HFP changes.

I put my HFP edits here.

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Ludovicus_Maior's picture

Re: Emmaleah's picture Tested proposed changes

I consolitated all the versions of RowUpdate() across the modules. 

The new CHAT functionality should be availible in ALL guides now as of 2.6.2 .

FWIW, the only place that it may not work right is the Professions module.  It needed most of the surgery.

Enjoy!   I'll add it to the doc, after I get back from my 10K race.  The gun goes off at 8 AM.

PS: I am hunting for a better icon.  I'll rev it for 2.6.2A, when I correct the profession guides.

Emmaleah's picture

RE: the icon

I realized (after I posted -- which was why I went and did the strikeout) that the upside down icon is actually the way it looks in game.  I still think its upside down, but I guess Blizzard likes it that way :) I did find a rightside up one on wowwiki, but I don't have a clue where to locate it to give an address in the code.

http://www.wowwiki.com/WoWWiki:List_of_mini_icons.

Did you know |ACH| is missing off of the syntax list, could you add it when you add |CHAT|

Im updating the Midsummer guide and went to look up how to use ACH right... and its not there :(

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Ludovicus_Maior's picture

Re: Reply to comment

Syntax guide updated, as per your command :-).

Now time to nap.