Just a few errors (as of 06:00 on Nov-8)

You are currently viewing a Wiki Page. It can be edited by anyone who is currently logged in. Before you change anything, please make sure to read our FAQ, the editing guidelines of this post as well as its comments.

OK. So now I have run my guide checker.

We have a bit of cleanup to do!

There are a few bogus errors, and some more stylistic problems, but all worth looking at.


Achievements

## WoWPro_Achievements/General/Emmaleah_Lorewalkers.lua @ http://wow-pro.com/wiki/lorewalkers_reputation_acheivement ! Line 172, for step l non-decimal L: [l Find a mailbox(Vale)|QID|31055|L|83769,83770,83771,83772,83773,83774,83777,83779,83780|N|Retrieve the items Lorewalker Cho has mailed to you.|] Emmaleah: The L tag does not support more than one item to loot on. One item and an optional space seprated count.

Dailies

## WoWPro_Dailies/Alliance/Raj_PetBattles.lua @ http://wow-pro.com/wiki/alliance_pet_battle_dailies ! Line 189, for step R duplicate tag N: [R Inkgill Mere|QID|32604|M|67.87,84.71|Z|Kun-Lai Summit|N|Open your treasure|U|93149|N|Open your treasure bag as you fly to the next spot.|] ! Line 189 for step R has unknown tag [Open your treasure bag as you fly to the next spot.]: [R Inkgill Mere|QID|32604|M|67.87,84.71|Z|Kun-Lai Summit|N|Open your treasure|U|93149|N|Open your treasure bag as you fly to the next spot.|] ! Line 208, for step R duplicate tag M: [R Krasari Falls|QID|32868|M|36.23,37.34|Z|Krasarang Wilds|M|62.2,45.8|U|89125|N|You can open your treasure bag while you are flying to the next spot.|] ! Line 208 for step R has unknown tag [62.2,45.8]: [R Krasari Falls|QID|32868|M|36.23,37.34|Z|Krasarang Wilds|M|62.2,45.8|U|89125|N|You can open your treasure bag while you are flying to the next spot.|] ## WoWPro_Dailies/Horde/Emm_PetBattles.lua @ http://wow-pro.com/wiki/horde_pet_battle_dailies ! Line 207, for step R duplicate tag M: [R Krasari Falls|QID|32868|M|36.23,37.34|M|62.2,45.8|Z|Krasarang Wilds|] ! Line 207 for step R has unknown tag [62.2,45.8]: [R Krasari Falls|QID|32868|M|36.23,37.34|M|62.2,45.8|Z|Krasarang Wilds|] ## WoWPro_Dailies/Horde/KatM_Thunder.lua @ http://wow-pro.com/wiki/isle_thunder_horde ! Line 88, for step A non-decimal NPC: [A Rommath's Quest|QID|*|NPC||PRE|32728|M|33,52.6|N|From Grand Magister Rommath|] ! Line 89, for step A non-decimal NPC: [A Firehawk's Quests|QID|*|NPC||PRE|32728|M|33,52.8|N|From Captain Aerthas Firehawk|] ! Line 90, for step A non-decimal NPC: [A Brightlock's Quests|QID|*|NPC||PRE|32728|M|33,52.6|N|From Ryshelle Brightlock|] ! Line 107 for step C has 1 M coords: [C Soul Surrender|QID|32220|M||QO|Scouts rescued: 6/6|N|Look for Scouts of either faction that are being zapped by Soulrippers and kill the soulripper. There are also scouts in cages.|] ! Line 127 for step A has 1 M coords: [A Skin of the Saurok|QID|32507|PRE|32730|M||N|From ???|] ! Line 129, for step A non-decimal NPC: [A Sunreaver's Quests|QID|*|NPC||PRE|32730|M|46.8,66.8|N|From Archmage Aethas Sunreaver|] ! Line 130, for step A non-decimal NPC: [A Amalia's Quests|QID|*|NPC||PRE|32730|M||N|From Penshire|] ! Line 130 for step A has 1 M coords: [A Amalia's Quests|QID|*|NPC||PRE|32730|M||N|From Penshire|] ! Line 131 for step A has 1 M coords: [A The Residents of Ihgaluk|QID|32274|PRE|32730|M||N|From Sunwalker Dezco|] ! Line 146 for step T has 1 M coords: [T Just Some Light Clean-Up Work|QID|32299|M||N|From Amalia Penshire|] ! Line 165 for step T has 1 M coords: [T De-Constructed|QID|32255|M||N|From Archmage Aethas Sunreaver|] ## WoWPro_Dailies/Neutral/Emm_Tillers.lua @ http://wow-pro.com/wiki/tillers_reputation ! Line 321 for step C has unknown tag [In the market or on the dock (where the green dot is).]: [C Talk to Fish|QID|31534|NC|L|87556|M|41.7,30.0|In the market or on the dock (where the green dot is).|]

WorldEvents

## WoWPro_WorldEvents/Alliance/Ludo_Noblegarden.lua @ None ! Line 18 for step F has unknown tag [Elwynn Forest]: [F Spring Fling - Goldshire|QID|927970004|M|42.2,65.8|Z|Z|Elwynn Forest|ACH|2797;4|N|Head to Goldshire and find a bunny to love.|] ! Line 25 for step F has unknown tag [First Fly to Un'Goro Crater's Golakka Hot Springs]: [F Hard Boiled|QID|927970003|M|30,50|Z|Un'Goro Crater|ACH|2797;3|First Fly to Un'Goro Crater's Golakka Hot Springs|]

Comments

Ludovicus_Maior's picture

Guide Parser Rework Angst

It is not a good thing that I have to run a Python program to syntax check the guides.

The current style of parsing that the WoWPro.ParseQuestLine() function uses ( text:match("|N|([^|]*)|?") for example) makes the assumption that tags appear once and that duplicates dont matter. 

A redesign of the parser to classify tags into tags with and without arguments, the style of argument and an optional verifier would go far in enforcing cleaner guides.

I wish I had though of this earlier.   It may be to late to do this before the next release, as getting the alliance guides into shape is a higher priority for the next release, along with critical bugs.

 

Ludovicus_Maior's picture

Out of game check pass, in game checks do not.

All of the guide errors above have been fixed, with the exception of Emmaleah's Lorewalker L tag.

When I ran the in game checker, I have a few guide sucessor errors to fix Alliance side and zone problems Horde side.

I do have some zone name corrections to make where I have failed to incorporate some of Emmaleah's changes for the new Draenor zones that should fix most of the Horde errors.

Update:  I have checked in Emmaleah's map updates and most of the guide errors are fixed.   I'll have to make another pass at the guides shortly. (8:51 8/11)     But It is time to go out and by thermal underwear and do guy stuff shopping before anyone is at the store.  Back later!

 

Emmaleah's picture

guy stuff...

Is that like when the Riko, the Hozen says, "Kiryn and Shokia skipped off to do girl stuff"

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Ludovicus_Maior's picture

Guy .vs. Girl stuff

Yup!

Ludovicus_Maior's picture

Next Phase this afternoon

OK.  Got back from Guy shopping.  Underwear, socks, new thermal underwear, rum, bourboun, and lots of red wine.

Needed to add entries for the shrines in Vale of Eternal Blossoms, as they have had the maps change.

Now all the references in the guides need to be updated.

 

Emmaleah's picture

lorewalkers

I fixed that... doh! I put in the new stuff, but didn't delete the original. All better now. 

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Ludovicus_Maior's picture

Not bad!

There was a major cleanup through the night.

11 guides need small tweaks and I can do those this morning.

 

Looking Better

That list is looking a whole lot better now :)

Emmaleah's picture

wow. nice script.

I will work on correcting these friday.

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Emmaleah's picture

so, stylistically speaking

R steps that are not the name of the subzone are needed sometimes, particularly for things like "Deepholm portal. Is there a way to not generate an error.  Maybe Deepholm  (portal)? Then it auto completes when you arrive at the other side,  except I'm not sure it would autocomplete...it would have to be temple of earth  (portal) which I feel would be less useful.

 Thoughts?

Emmaleah == bravely leading the way since ... um a long time ago... Smiling

Auto-complete on location is

Auto-complete on location is |M|00,00|CC|

If I wanted someone to use a portal, I'd use R Destination Zone, and give a note about using the portal (and where to find it), so if I wanted them to use a portal to get to Deepholm, I'd have have R Deepholm |N|Use the portal at XXX to get you to Deepholm.|M|0_Portal_Location_0|